Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alsa-ucm-conf: fix hardcoded path to /bin/rm and /bin/mkdir #371100

Closed
wants to merge 2 commits into from

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jan 5, 2025

This fix #294170

Question: Should I add coreutils to buildInputs ?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol marked this pull request as ready for review January 5, 2025 11:23
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/dell-xps-13-9320-microphone-not-working/40932/8

@kirillrdy
Copy link
Member

Question: Should I add coreutils to buildInputs ?

my guess would be no

@drupol
Copy link
Contributor Author

drupol commented Jan 5, 2025

I just notice that this should go to staging... rebase ongoing.

@drupol drupol marked this pull request as draft January 5, 2025 11:37
@drupol drupol force-pushed the push-ytnprzvyuluv branch from 66565a1 to 9613a91 Compare January 5, 2025 11:38
@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: haskell 6.topic: qt/kde 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: rust 6.topic: golang 6.topic: fetch 6.topic: stdenv Standard environment 6.topic: nodejs 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: systemd 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET 6.topic: nvidia labels Jan 5, 2025
@drupol drupol changed the base branch from master to staging January 5, 2025 11:38
@drupol drupol deleted the push-ytnprzvyuluv branch January 5, 2025 12:02
@nix-owners nix-owners bot requested review from maralorn and nomeata January 5, 2025 12:02
@drupol drupol restored the push-ytnprzvyuluv branch January 5, 2025 12:04
@drupol drupol deleted the push-ytnprzvyuluv branch January 5, 2025 12:05
@NixOS NixOS locked as spam and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alsa-ucm-conf refers to /bin/rm and /bin/mkdir
3 participants