Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] pcmciaUtils: Fix udev rule path #371061

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

nix-backports[bot]
Copy link

@nix-backports nix-backports bot commented Jan 5, 2025

Bot-based backport to release-24.11, triggered by a label in #370912.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

The pcmciaUtils udev rules failed to apply, as some paths were not
replaced correctly. For example, the following udev line is in the
source package:

SUBSYSTEM=="pcmcia", ENV{MODALIAS}=="?*", \
		RUN+="__UDEVHELPERDIR__/pcmcia-check-broken-cis"

The Makefile by default replaces the `__UDEVHELPERDIR__` with
`${prefix}/lib/udev`, which is the wrong place on NixOS. To quickly set
the correct path, just replace this placeholder string directly. With
this patch, the udev rules can be applied, as it is done with
`hardware.pcmcia.enable`. The files are referenced correctly and pcmcia
works fine on real hardware.

(cherry picked from commit 39e440a)
@nix-backports nix-backports bot mentioned this pull request Jan 5, 2025
14 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 5, 2025
@drupol drupol merged commit 3dc1688 into release-24.11 Jan 5, 2025
20 of 24 checks passed
@drupol drupol deleted the backport-370912-to-release-24.11 branch January 5, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants