Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] various: remove code for macOS < 11 #370999

Merged
merged 4 commits into from
Jan 5, 2025
Merged

[staging] various: remove code for macOS < 11 #370999

merged 4 commits into from
Jan 5, 2025
+4 −42

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jan 4, 2025

staging counterpart to #370995.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 4, 2025
@nix-owners nix-owners bot requested a review from matthewbauer January 4, 2025 23:07
emilazy added 2 commits January 5, 2025 04:19
@emilazy
libepoxy: remove code for macOS < 11
b01bac1
@emilazy
Revert "inetutils: fix build on x86_64-darwin"
31b249a 
Should no longer be necessary, per the comment.

This reverts commit 2feff8a.
@emilazy emilazy force-pushed the push-vkkulxnlnyyt branch from 22faaa5 to 31b249a Compare January 5, 2025 04:20
@emilazy emilazy marked this pull request as ready for review January 5, 2025 04:23
@nix-owners nix-owners bot requested a review from fgaz January 5, 2025 04:25
paparodeo
paparodeo reviewed Jan 5, 2025
View reviewed changes
Copy link
Contributor

@paparodeo paparodeo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgs/development/libraries/libepoxy/default.nix builds fine on x64 darwin (as well as the other packages)

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 5, 2025
@emilazy emilazy merged commit 59d3f18 into NixOS:staging Jan 5, 2025
26 of 30 checks passed
@emilazy emilazy deleted the push-vkkulxnlnyyt branch January 5, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paparodeo paparodeo paparodeo approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@fgaz fgaz Awaiting requested review from fgaz

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 5001+ 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilazy @paparodeo @wegank