Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fityk,xylib: fix cross / strictDeps build #370617

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fityk,xylib: fix cross / strictDeps build #370617

wants to merge 2 commits into from

Conversation

FliegendeWurst
Copy link
Member

ref. #178468

Things done

  • Built on platform(s)
    • x86_64-linux: and cross to aarch64
    • aarch64-linux
  • Fits CONTRIBUTING.md.

@FliegendeWurst FliegendeWurst added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 3, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 3, 2025
@nix-owners nix-owners bot requested a review from pSub January 3, 2025 14:26
uninsane
uninsane reviewed Jan 5, 2025
View reviewed changes
Copy link
Contributor

@uninsane uninsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds for me after removing swig from buildInputs and cherry-picking the unbound cross fix from staging (a36d820)

pkgs/by-name/fi/fityk/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uninsane uninsane uninsane approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FliegendeWurst @uninsane @wegank