Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paperwork: fix installing translations #370379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

symphorien
Copy link
Member

without this backport, paperwork is always in english

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@symphorien symphorien added the backport release-24.11 Backport PR automatically label Jan 2, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 2, 2025
@symphorien symphorien removed the backport release-24.11 Backport PR automatically label Jan 2, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 4, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370379


x86_64-linux

✅ 18 packages built:
  • paperwork
  • paperwork.dist
  • python312Packages.openpaperwork-core
  • python312Packages.openpaperwork-core.dist
  • python312Packages.openpaperwork-gtk
  • python312Packages.openpaperwork-gtk.dist
  • python312Packages.paperwork-backend
  • python312Packages.paperwork-backend.dist
  • python312Packages.paperwork-shell
  • python312Packages.paperwork-shell.dist
  • python313Packages.openpaperwork-core
  • python313Packages.openpaperwork-core.dist
  • python313Packages.openpaperwork-gtk
  • python313Packages.openpaperwork-gtk.dist
  • python313Packages.paperwork-backend
  • python313Packages.paperwork-backend.dist
  • python313Packages.paperwork-shell
  • python313Packages.paperwork-shell.dist

@nix-owners nix-owners bot requested a review from aszlig January 4, 2025 15:59
@symphorien symphorien added the backport release-24.11 Backport PR automatically label Jan 4, 2025
Copy link
Member

@aszlig aszlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, otherwise LGTM.

pkgs/applications/office/paperwork/src.nix Outdated Show resolved Hide resolved
without this backport, paperwork is always in english
@symphorien
Copy link
Member Author

TIL about srcOnly
Thanks

@lucasew
Copy link
Contributor

lucasew commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370379


x86_64-linux

✅ 18 packages built:
  • paperwork
  • paperwork.dist
  • python312Packages.openpaperwork-core
  • python312Packages.openpaperwork-core.dist
  • python312Packages.openpaperwork-gtk
  • python312Packages.openpaperwork-gtk.dist
  • python312Packages.paperwork-backend
  • python312Packages.paperwork-backend.dist
  • python312Packages.paperwork-shell
  • python312Packages.paperwork-shell.dist
  • python313Packages.openpaperwork-core
  • python313Packages.openpaperwork-core.dist
  • python313Packages.openpaperwork-gtk
  • python313Packages.openpaperwork-gtk.dist
  • python313Packages.paperwork-backend
  • python313Packages.paperwork-backend.dist
  • python313Packages.paperwork-shell
  • python313Packages.paperwork-shell.dist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants