Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/kmonad: avoid running an unnecessary bash #370064

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Jan 1, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jian-lin jian-lin requested a review from r-vdp January 1, 2025 22:46
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 1, 2025
@r-vdp
Copy link
Contributor

r-vdp commented Jan 2, 2025

The commit messages and PR descriptions say kanata, but what's changed is the kmonad module 😬

@jian-lin jian-lin force-pushed the pr/kmonad-avoid-bash branch from 4dd5c82 to c3588cf Compare January 2, 2025 18:22
@jian-lin jian-lin changed the title nixos/kanata: avoid running an unnecessary bash nixos/kmonad: avoid running an unnecessary bash Jan 2, 2025
@jian-lin
Copy link
Contributor Author

jian-lin commented Jan 2, 2025

kanata is a similar tool I maintain in Nixpkgs and used to use. 😅

Nice catch. Fixed.

@jian-lin jian-lin added the backport release-24.11 Backport PR automatically label Jan 2, 2025
@jian-lin jian-lin merged commit aff999e into NixOS:master Jan 2, 2025
33 of 34 checks passed
@jian-lin jian-lin deleted the pr/kmonad-avoid-bash branch January 2, 2025 23:22
@nix-backports
Copy link

nix-backports bot commented Jan 2, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants