Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24.05 is unmaintained #369784

Merged
merged 2 commits into from
Dec 31, 2024
Merged

24.05 is unmaintained #369784

merged 2 commits into from
Dec 31, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented Dec 31, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: policy discussion 6.topic: lib The Nixpkgs function library 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 31, 2024
@wegank wegank marked this pull request as ready for review December 31, 2024 21:24
@Mic92 Mic92 merged commit 2489bd6 into NixOS:master Dec 31, 2024
29 of 30 checks passed
@wegank wegank deleted the 24.05-unmaintained branch December 31, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azuwis azuwis Awaiting requested review from azuwis

@infinisil infinisil Awaiting requested review from infinisil

@LeSuisse LeSuisse Awaiting requested review from LeSuisse

@Mic92 Mic92 Awaiting requested review from Mic92

@mweinelt mweinelt Awaiting requested review from mweinelt

@risicle risicle Awaiting requested review from risicle

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: lib The Nixpkgs function library 6.topic: policy discussion 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wegank @Mic92