docs: init lib.stringsWithDeps.textClosureList #369776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsjobeki
force-pushed
the
doc/depstring
branch
3 times, most recently
from
cb298d2 to
f0522ff
Compare
There was a problem hiding this comment.
Seems about right, except for some clarity/precision nits. But given it's an essentially dead thing and features extraordinarily bad naming but toposorting is actually nice to have, why don't we borrow (i.e. upstream) and promote Home Manager's DAG lib?
hsjobeki
force-pushed
the
doc/depstring
branch
from
f0522ff to
442416a
Compare
h7x4
approved these changes
Jan 7, 2025
h7x4
reviewed
Jan 7, 2025
| - Ordering the dependent phases of `system.activationScripts` | ||
| - Ordering the dependent phases of `system.userActivationScripts` | ||
|
|
||
| For further examples see: [NixOS activation script)(https://nixos.org/manual/nixos/stable/#sec-activation-script) |
There was a problem hiding this comment.
Suggested change
| For further examples see: [NixOS activation script)(https://nixos.org/manual/nixos/stable/#sec-activation-script) | |
| For further examples see: [NixOS activation script](https://nixos.org/manual/nixos/stable/#sec-activation-script) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init doc-comment for
lib.stringsWithDeps.textClosureListThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.