Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uuu: fix passthru.updateScript version's regex to proper match the version #369752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

uuu: fix passthru.updateScript version's regex to proper match the version #369752

wants to merge 1 commit into from

Conversation

otavio
Copy link
Contributor

@otavio otavio commented Dec 31, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@otavio otavio requested a review from NickCao December 31, 2024 19:13
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 31, 2024
thiagokokada
thiagokokada requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#365186

@otavio
Copy link
Contributor Author

otavio commented Jan 3, 2025

@thiagokokada, I saw the pull request you mentioned; however, I don't think the changes for this specific recipe are right. Without the change I'm making here, the package update will not succeed.

I noticed the error in this recipe when I ran the update script across all the packages I maintain.

@thiagokokada
Copy link
Contributor

CC @piegamesde.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piegamesde piegamesde piegamesde approved these changes

@NickCao NickCao Awaiting requested review from NickCao

@thiagokokada thiagokokada Awaiting requested review from thiagokokada

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@otavio @thiagokokada @piegamesde @wegank