Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify-osd: 0.9.34 → 0.9.35+20.04.20191129 #369308

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Dec 30, 2024

Borrowed build ideas mostly from Arch’s self-hosted code forge for packages (would be great if Nixpkgs followed suit & self-hosted to respect user privacy & not feed the corporate beast)… with a little additions from pkgs.notify-osd-customizable.

This should fix MS GitHub issue #369235

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

@toastal toastal requested review from Artturin and bodil December 30, 2024 05:44
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 30, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 30, 2024
@korrat
Copy link
Contributor

korrat commented Jan 4, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369308


x86_64-linux

✅ 2 packages built:
  • notify-osd
  • nyxt

@toastal toastal changed the title notify-osd: 0.9.24 → 0.9.35+20.04.20191129 notify-osd: 0.9.34 → 0.9.35+20.04.20191129 Jan 5, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369308


x86_64-linux

✅ 2 packages built:
  • notify-osd
  • nyxt

aarch64-linux

✅ 2 packages built:
  • notify-osd
  • nyxt

@toastal toastal force-pushed the notify-osd-0.9.35 branch from 605859c to 0214d29 Compare January 6, 2025 15:35
Borrowed build changes from Arch’s notify-osd + Nixpkgs’s
notify-osd-customizable.

It would be wonderful if Nixpkgs, like Arch, could self-host their code
forge so we weren’t required to have accounts with or interact with
proprietary, US-based Microsoft GitHub.
@toastal toastal force-pushed the notify-osd-0.9.35 branch from 0214d29 to 5f7c819 Compare January 6, 2025 15:36
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Jan 6, 2025
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369308


x86_64-linux

✅ 2 packages built:
  • notify-osd
  • nyxt

aarch64-linux

✅ 2 packages built:
  • notify-osd
  • nyxt

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 6, 2025
@GaetanLepage GaetanLepage requested a review from drupol January 6, 2025 16:36
@Artturin Artturin merged commit 53d5113 into NixOS:master Jan 6, 2025
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants