-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notify-osd: 0.9.34 → 0.9.35+20.04.20191129 #369308
Merged
Merged
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toastal
force-pushed
the
notify-osd-0.9.35
branch
from
December 30, 2024 05:48
58cf1f2
to
605859c
Compare
github-actions
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Dec 30, 2024
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
labels
Dec 30, 2024
|
toastal
changed the title
notify-osd: 0.9.24 → 0.9.35+20.04.20191129
notify-osd: 0.9.34 → 0.9.35+20.04.20191129
Jan 5, 2025
|
GaetanLepage
reviewed
Jan 6, 2025
toastal
force-pushed
the
notify-osd-0.9.35
branch
from
January 6, 2025 15:35
605859c
to
0214d29
Compare
Borrowed build changes from Arch’s notify-osd + Nixpkgs’s notify-osd-customizable. It would be wonderful if Nixpkgs, like Arch, could self-host their code forge so we weren’t required to have accounts with or interact with proprietary, US-based Microsoft GitHub.
toastal
force-pushed
the
notify-osd-0.9.35
branch
from
January 6, 2025 15:36
0214d29
to
5f7c819
Compare
github-actions
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
labels
Jan 6, 2025
GaetanLepage
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
wegank
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowed build ideas mostly from Arch’s self-hosted code forge for packages (would be great if Nixpkgs followed suit & self-hosted to respect user privacy & not feed the corporate beast)… with a little additions from
pkgs.notify-osd-customizable
.This should fix MS GitHub issue #369235
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.
1
Footnotes
Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩