dotnetCorePackages.dotnet_{8,9}.vmr: switch CDN URL #367825
Conversation
github-actions
bot
added
6.topic: dotnet
|
| @@ -129,6 +129,7 @@ writeScript "update-dotnet-vmr.sh" '' | |||
| map(select(.PrivateSourceBuiltArtifactsUrl)) | |||
| | .[] | .PrivateSourceBuiltArtifactsUrl' eng/Versions.props) | |||
| fi | |||
| artifactsUrl="''${artifactsUrl/dotnetcli.azureedge.net/builds.dotnet.microsoft.com}" | |||
There was a problem hiding this comment.
we should maybe leave a comment indicating this is temporary until the release tarballs are fixed?
There was a problem hiding this comment.
Given they won't use these URLs ever again, I don't know if it is really temporary.
They said they don't know for how long they'll be able to use the *.azureedge.net domain for.
There was a problem hiding this comment.
I just mean presumably they will update the urls in the VMR repo in the future, so we won't need to replace them.
There was a problem hiding this comment.
True, I was thinking more of previous versions but we don't need to keep supporting those now that I think of it.
|
can we fix the: as well so it works if we later remove the substitution below? |
As it was announced in dotnet/announcements#336, the CDN for .NET assets is changing, so change those ahead of time.
GGG-KILLER
force-pushed
the
dotnet-cdn-change
branch
from
99bd715 to
3ffc71f
Compare
done |
|
Successfully created backport PR for |
As it was announced in dotnet/announcements#336, the CDN for .NET assets is changing, so change those ahead of time.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.