Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pytorch: just disable -Werror; fix darwin x64 build #367312

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

paparodeo
Copy link
Contributor

pytorch and many of the vendored libs build with -Werror and the derivation meticulously then disables any warning that results in a build failure. Just disable -Werror and fix the x64 darwin build.

https://hydra.nixos.org/build/282440946

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pytorch and many of the vendored libs build with -Werror and the
derivation meticulously then disables any warning that results in a
build failure. Just disable -Werror and fix the x64 darwin build.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 22, 2024
@ofborg ofborg bot requested review from tscholak, thoughtpolice and teh December 22, 2024 22:22
@paparodeo
Copy link
Contributor Author

@ofborg build python312Packages.pytorch

@vcunat vcunat changed the base branch from staging-next to master December 23, 2024 14:00
@paparodeo paparodeo changed the title [staging-next] python312Packages.pytorch: just disable -Werror; fix darwin x64 build python312Packages.pytorch: just disable -Werror; fix darwin x64 build Dec 23, 2024
@GaetanLepage
Copy link
Contributor

That's a more radical solution, but it's fine by me.
I'll let @SomeoneSerge have the final word on this.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 2, 2025
Copy link
Contributor

@SomeoneSerge SomeoneSerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I can hardly see how -Werror is useful at deployment time. It would make more sense in a devShell`

@GaetanLepage GaetanLepage merged commit 5242338 into NixOS:master Jan 2, 2025
58 of 59 checks passed
@paparodeo paparodeo deleted the pytorch-no-werror branch January 4, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants