Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/hostapd: add passwordFile to structured SAE entries #365727

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oddlama
Copy link
Contributor

@oddlama oddlama commented Dec 16, 2024

This adds a passwordFile option for the structured sae settings,
which is more convenient than constructing the file manually via saePasswordFile.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 16, 2024
@oddlama oddlama requested review from rnhmjoj and K900 December 20, 2024 14:18
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 31, 2024
@oddlama oddlama force-pushed the update-hostapd-config branch from 26830e2 to e1f396a Compare January 3, 2025 19:30
@oddlama
Copy link
Contributor Author

oddlama commented Jan 3, 2025

  • Rebased on master

Copy link
Contributor

@PatrickDaG PatrickDaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 4, 2025
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 4, 2025

Does it still make sense to have saePasswordsFile now? I think having saePasswords, saePasswordsFiles and saePasswords.*.passwordFile is a bit confusing.

@oddlama
Copy link
Contributor Author

oddlama commented Jan 4, 2025

Definitely a bit confusing, but I didn't want to introduce a breaking change by removing the saePasswordsFile option. There might still be merit to this option though, if you are trying to hide MAC addresses from a public repository.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants