-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/tzupdate: make enabled module actually be enabled #361373
base: master
Are you sure you want to change the base?
Conversation
Eval summary
|
a5c288b
to
55898d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first commit's commit message is outdated with the addition of the second one, maybe that can be updated.
Generally, when making changes such as this you will want to rebase and alter existing commits instead of adding another commit, as this keeps the commit history of the project clean once merged and makes it much easier for everyone else to work with after the fact. Rebasing will also allow you to change commit messages in addition to the commit contents. Specifically, you will want to look up how to do interactive rebasing using Git. |
I maintain other open source projects. Over time I've noticed it takes more time to explain rebases than to click the merge and squash button that github offers, mostly if there's just one meaningful change to record in history. It also makes contribution experience more pleasant because there are less details to care about. I respect the decision here nevertheless and will rebase. |
Without this fix, when setting `services.tzupdate.enable = true`, the service would never run automatically. Now, it's actually enabled in systemd and it actually gets executed. Still, it could be improved with a timer as explained in NixOS#127984 (comment), but this makes it at least work out of the box when rebooting the system.
98a792d
to
b2543bf
Compare
Without this fix, when setting
services.tzupdate.enable = true
, the service would never run automatically.Now, it's actually enabled in systemd and it actually gets executed.
Still, it could be improved with a timer as explained in #127984 (comment), but this makes it at least work out of the box when rebooting the system.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.