Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raylib: 5.0 -> 5.5, cleanup/fix, add diniamo as a maintainer #357729

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

diniamo
Copy link
Contributor

@diniamo diniamo commented Nov 21, 2024

  • Update from 5.0 to 5.5
  • Avoid with lib;
  • Remove redundant inputs
  • Sync dependencies with Raylib wiki
  • Reorder some parts to make sense
  • Add platform argument
  • Only enable one audio backend by default, and don't add them to buildInputs
  • Format with nixfmt-rfc-style

Help would be appreciated with getting the missing platforms to build, and I don't have the capacity to figure those out.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@diniamo diniamo force-pushed the update-raylib branch 3 times, most recently from 808afec to c9245a9 Compare November 21, 2024 01:27
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Nov 22, 2024
@diniamo diniamo mentioned this pull request Nov 23, 2024
13 tasks
@diniamo diniamo changed the title raylib: 5.0 -> 5.5, cleanup raylib: 5.0 -> 5.5, cleanup/fix, add diniamo as a maintainer Nov 25, 2024
@ofborg ofborg bot requested review from ehmry and Sigmanificient December 2, 2024 06:28
pkgs/by-name/ra/raylib/package.nix Outdated Show resolved Hide resolved
@diniamo diniamo force-pushed the update-raylib branch 2 times, most recently from a1afdbf to 425473b Compare December 7, 2024 06:48
@ofborg ofborg bot requested review from ehmry and Sigmanificient December 8, 2024 00:32
@diniamo
Copy link
Contributor Author

diniamo commented Dec 9, 2024

@ehmry is there anything else before we can get this in?

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 30, 2024
- Update from 5.0 to 5.5
- Avoid `with lib;`
- Remove redundant inputs
- Sync dependencies with Raylib wiki
- Reorder some parts to make sense
- Add platform argument
- Only enable one audio backend by default, and don't add them to
buildInputs
- Format with nixfmt-rfc-style
@diniamo
Copy link
Contributor Author

diniamo commented Jan 2, 2025

Forgot to revert the changes to the other packages along with the propagated inputs one.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 2, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 2, 2025
@ehmry ehmry merged commit 47b52e6 into NixOS:master Jan 3, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person ofborg-internal-error Ofborg encountered an error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants