cosmic-packages: move to new cargo fetcher

[JohnRTitor]

Manually did it by hand. Though we should probably consider creating a script to get rid of other excess Cargo.locks.

Originally intended as part of #356385 but split to make reviews easier

CC: #327063

Closes #356821

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[a-kenji]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356539

---

x86_64-linux

✅ 20 packages built:

• cosmic-applibrary
• cosmic-bg
• cosmic-comp
• cosmic-comp.debug
• cosmic-design-demo
• cosmic-edit
• cosmic-files
• cosmic-greeter
• cosmic-launcher
• cosmic-notifications
• cosmic-osd
• cosmic-panel
• cosmic-randr
• cosmic-session
• cosmic-settings
• cosmic-settings-daemon
• cosmic-store
• cosmic-term
• cosmic-workspaces-epoch
• cosmic-workspaces-epoch.debug

[a-kenji]

Thank you for splitting this in to reviewable chunks.

I have not tried every functionality of the packages in here, but ran every output against master to see if they match up.

For programs like cosmic-edit I tried them out manually.

[JohnRTitor]

@ofborg build cosmic-applibrary cosmic-bg cosmic-comp cosmic-design-demo cosmic-edit cosmic-files cosmic-greeter cosmic-launcher cosmic-notifications cosmic-osd cosmic-panel cosmic-randr cosmic-session cosmic-settings cosmic-settings-daemon cosmic-store cosmic-term cosmic-workspaces-epoch

[TomaSajt]

There still seems to be an issue with git fetching, maybe submodule related.

You can see in the logs that the call to nix-prefetch-git caused the build faliure.

Seeing a lot of http 403 codes.

Originally git repos were fetched sequentially outside of the multiprocessing part. Maybe I should restore the logic to be like that.

[JohnRTitor]

Originally git repos were fetched sequentially outside of the multiprocessing part.

Perhaps it should respect enableParallelBuilding?

EDIT: enableParallelBuilding may not mean parallelFetching, I suppose

[TomaSajt]

Okay, seems like decreasing the concurrency limit works for OfBorg. I didn't encounter issues locally, even when trying to build all cargoDeps at the same time. Opened a separate PR and cherry picked its commit into this PR.

[TomaSajt]

I also saw that #356743 added some retry logic, maybe that could also be incorporated later.

[ahoneybun]

@JohnRTitor does this change stop us from using nix-update to update our packaging?

[JohnRTitor]

@ofborg build cosmic-applibrary cosmic-bg cosmic-comp cosmic-design-demo cosmic-edit cosmic-files cosmic-greeter cosmic-launcher cosmic-notifications cosmic-osd cosmic-panel cosmic-randr cosmic-session cosmic-settings cosmic-settings-daemon cosmic-store cosmic-term cosmic-workspaces-epoch

[JohnRTitor]

It won't "stop" you, nix update just isn't compatible with it since it's a new fetcher. See Mic92/nix-update#298, adding support should be one PR away

[SuperSandro2000]

That tastes good :P