Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gurk-rs: 0.5.1 -> 0.5.2 #356353

Merged
merged 1 commit into from
Nov 19, 2024
Merged

gurk-rs: 0.5.1 -> 0.5.2 #356353

merged 1 commit into from
Nov 19, 2024
+7 −5,746

Conversation

kachick
Copy link
Member

@kachick kachick commented Nov 16, 2024 •
edited
Loading

Changes: boxdot/gurk-rs@v0.5.1...v0.5.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kachick

This comment was marked as outdated.

Sign in to view
@kachick kachick requested a review from devhell November 16, 2024 05:06
devhell
devhell approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@devhell devhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@ofborg ofborg bot requested a review from devhell November 16, 2024 17:19
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 17, 2024
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356353

x86_64-linux

❌ 1 package failed to build:
  • gurk-rs

aarch64-linux

❌ 1 package failed to build:
  • gurk-rs

x86_64-darwin

❌ 1 package failed to build:
  • gurk-rs

aarch64-darwin

❌ 1 package failed to build:
  • gurk-rs

khaneliman
khaneliman reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... seeing hash mismatch

pkgs/applications/networking/instant-messengers/gurk-rs/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/instant-messengers/gurk-rs/default.nix Outdated Show resolved Hide resolved
@kachick kachick marked this pull request as draft November 19, 2024 02:57
@kachick @khaneliman
gurk-rs: 0.5.1 -> 0.5.2
9e33590 
gurk-rs: restrict rev with adding "refs/tags/" prefix
gurk-rs: update cargoHash

Co-authored-by: Austin Horstman <[email protected]>
@khaneliman
Copy link
Contributor

khaneliman commented Nov 19, 2024 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356353

x86_64-linux

✅ 1 package built:
  • gurk-rs

aarch64-linux

✅ 1 package built:
  • gurk-rs

x86_64-darwin

✅ 1 package built:
  • gurk-rs

aarch64-darwin

❌ 1 package failed to build:
  • gurk-rs

Weird error on darwin community builder.. lol

 cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/2G0KA3I30IJMN/Cocoa-3MON0LI0S2WF0.pcm': 'No such file or directory'
┃        >   cargo:warning=In file included from objc/notify.m:1:
┃        >   cargo:warning=objc/notify.h:1:9: fatal error: could not build module 'Cocoa'
┃        >   cargo:warning=#import <Cocoa/Cocoa.h>
┃        >   cargo:warning= ~~~~~~~^
┃        >   cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/2G0KA3I30IJMN/CoreServices-U92Y0EZNA19C.pcm': 'No such file or directory'
┃        >   cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/2G0KA3I30IJMN/Foundation-3GAPJMVYJZSH2.pcm': 'No such file or directory'
┃        >   cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/2G0KA3I30IJMN/ObjectiveC-1ONP05PEXK7R6.pcm': 'No such file or directory'
┃        >   cargo:warning=5 errors generated.

@kachick
Copy link
Member Author

kachick commented Nov 19, 2024

I don't have aarch64-darwin device, so checking it in GitHub hosted macos-15 runner. It returns success 🤔

aarch64-darwin

✅ 1 package built:
  • gurk-rs

@kachick kachick marked this pull request as ready for review November 19, 2024 03:35
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356353

x86_64-linux

✅ 1 package built:
  • gurk-rs

aarch64-linux

✅ 1 package built:
  • gurk-rs

x86_64-darwin

✅ 1 package built:
  • gurk-rs

aarch64-darwin

✅ 1 package built:
  • gurk-rs

@khaneliman
Copy link
Contributor

I don't have aarch64-darwin device, so checking it in GitHub hosted macos-15 runner. It returns success 🤔

aarch64-darwin

✅ 1 package built:

I ran it again, it looked like a transient error from the new fetcher.

@TomaSajt
Copy link
Contributor

The last force push brought in the commit that now also fetches submodules.

nixpkgs-review failed because it is automatically rebasing on master, which already had that change.

the force push: https://github.com/NixOS/nixpkgs/compare/df54d02219152c3bfd69f268686e04ad17158a2f..9e335902fb3efcfbd279680aabcfdaa2005da342#diff-77d6ed0c1e97de400495829ad6c81d6da127ff83ff09d6d14ec9f887f46d4c67

@kachick
Copy link
Member Author

kachick commented Nov 19, 2024

Thank you for sharing that. The diff clarified why changed the result.

I have initially created this PR just after merging #349360, then master branch did not include #356415.

Anyway this useFetchCargoVendor much helped me, thank you! 🙏

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 19, 2024
@khaneliman khaneliman merged commit 9342b5d into NixOS:master Nov 19, 2024
30 of 31 checks passed
@kachick
Copy link
Member Author

kachick commented Nov 20, 2024

Thank you! 🙏

@kachick kachick deleted the update-gurk-rs branch November 20, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaneliman khaneliman khaneliman approved these changes

@devhell devhell Awaiting requested review from devhell

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kachick @khaneliman @TomaSajt @devhell @wegank