Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completely: 0.5.2 -> 0.6.3, move to by-name #354974

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

zendo
Copy link
Contributor

@zendo zendo commented Nov 10, 2024

https://github.com/DannyBen/completely/releases

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol
Copy link
Contributor

drupol commented Nov 10, 2024

Diff LGTM ! Thanks!

@zendo if you know ruby and if you have time, a little help is needed to upgrade bashly, feel free to ping me in a PR if you plan to have a look, that would be greatly appreciated. Thanks in advance.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 11, 2024
@tjni tjni merged commit 12569c1 into NixOS:master Nov 11, 2024
48 of 49 checks passed
@zendo zendo deleted the upd/completely branch November 11, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants