starc: init at 0.7.5 #354961
Merged
starc: init at 0.7.5 #354961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
pancaek
force-pushed
the
story-architect
branch
2 times, most recently
from
c45e45c to
7c1632a
Compare
NotAShelf
reviewed
Nov 10, 2024
pancaek
force-pushed
the
story-architect
branch
from
7c1632a to
4abbd63
Compare
|
🤦 I changed the pname when I shouldn't have, oops |
pancaek
force-pushed
the
story-architect
branch
2 times, most recently
from
da9e3f3 to
4de2839
Compare
ofborg
bot
added
8.has: package (new)
FliegendeWurst
added
the
12. first-time contribution
pancaek
force-pushed
the
story-architect
branch
from
4de2839 to
dd74758
Compare
FliegendeWurst
requested changes
Nov 27, 2024
Comment on lines
+40
to
+41
| makeWrapper ${starc-unwrapped}/bin/starc $out/bin/starc \ | ||
| --unset QT_PLUGIN_PATH |
There was a problem hiding this comment.
This will technically be a double wrapper (starc -> starc-unwrapped -> bwrap of appimage), but I don't think it really matters here.
pancaek
force-pushed
the
story-architect
branch
from
dd74758 to
751f2ae
Compare
github-actions
bot
added
10.rebuild-darwin: 0
ofborg
bot
added
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-linux: 0
FliegendeWurst
approved these changes
Dec 4, 2024
wegank
added
the
12.approvals: 1
pancaek
force-pushed
the
story-architect
branch
from
751f2ae to
693d698
Compare
github-actions
bot
removed
8.has: maintainer-list (update)
FliegendeWurst
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story Architect is the successor to Kit Scenarist, a screenwriting software.
homepage: https://starc.app/
Some notes on packaging: I would have liked to avoid using the stdenvNoCC here, but I wasn't successful in getting a wrapProgram to function correctly if placed in the fixupPhase of the appimageTools.wrapType2 itself. If someone else is able to get it to behave we could move most of the installPhase to the appimage's extraInstallCommands, and clean up the derivation significantly.
Also, I've elected for an unfree license, rather than GPL-3 as listed in the github repo, as some features of the paid version are proprietary.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.