Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundler: revert 4dd40b15d8 #353045

Merged
merged 1 commit into from
Nov 2, 2024
Merged

bundler: revert 4dd40b15d8 #353045

merged 1 commit into from
Nov 2, 2024

Conversation

itepastra
Copy link
Member

To fix nixosTests.gitlab I reverted the bundler update that broke it.

I know this isn't the best way to solve it, but I don't know a better way

closes #352963

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

revert the bundler update to fix the gitlab nixosTest,
gitlab apparently wants only the old version.
@itepastra itepastra marked this pull request as ready for review November 2, 2024 02:51
@vcunat vcunat requested a review from anthonyroussel November 2, 2024 06:27
@vcunat
Copy link
Member

vcunat commented Nov 2, 2024

OfBorg is slow, so: rebuild estimates are pretty small:

    284 x86_64-darwin
    578 x86_64-linux

and most importantly, nixosTests.gitlab got fixed for me (aarch64.nixos.community machine).

@vcunat vcunat merged commit 7ffd9ae into NixOS:master Nov 2, 2024
12 of 13 checks passed
@vcunat
Copy link
Member

vcunat commented Nov 2, 2024

Blocking the channel is bad, so let me merge this fast. Anyone, feel free to find a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: nixosTests.gitlab
2 participants