Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nexttrace: build with go 1.22 to fix darwin build #352581

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

BirkhoffLee
Copy link
Contributor

This project is meant to be build on Go 1.22 instead of any later versions

References:

Things done

New to Nix - not sure how to test, would love help on it

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Oct 31, 2024
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should target the master branch.

@Aleksanaa
Copy link
Member

@ofborg build nexttrace

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
This project is meant to be build on Go 1.22 instead of any later versions

References:
- nxtrace/NTrace-core#270
- nxtrace/NTrace-core#257
@Aleksanaa Aleksanaa added backport release-24.11 Backport PR automatically and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 5, 2024
@Aleksanaa
Copy link
Member

https://github.com/ofborg build nexttrace

@Aleksanaa
Copy link
Member

@ofborg build nexttrace

@Aleksanaa
Copy link
Member

Built on aarch64-darwin

@Aleksanaa Aleksanaa changed the title use go 1.22 to build nexttrace nexttrace: build with go 1.22 to fix darwin build Dec 5, 2024
@Aleksanaa Aleksanaa merged commit e23bacc into NixOS:master Dec 5, 2024
25 of 29 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 5, 2024

Successfully created backport PR for release-24.11:

nixpkgs-ci bot pushed a commit that referenced this pull request Dec 5, 2024
use go 1.22 to build nexttrace

This project is meant to be build on Go 1.22 instead of any later versions

References:
- nxtrace/NTrace-core#270
- nxtrace/NTrace-core#257

(cherry picked from commit e23bacc)
@tsosunchia
Copy link

tsosunchia commented Jan 17, 2025

nexttrace 已更新 Golang 版本到 v1.23
nxtrace/NTrace-core@69588b0
https://github.com/nxtrace/NTrace-core/releases/tag/v1.3.7

[English auto-translation] Upstream updated to Go 1.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle! backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants