-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
candy-icons: unstable-2023-12-31 -> 0-unstable-2024-10-22 #351624
Conversation
53007a2
to
2a25ce1
Compare
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for the PR and welcome to the community! 🎉
I recall the maintainer-list.nix
file having its own formatting rules, so please undo the formatting changes, other than the addition of your identity to the list. Thank you! 🙇
Hi, thanks for the hint! I guess it is fixed now! |
Looks good to me! |
For the record the upstream diff: EliverLara/candy-icons@e4464d7...f8a4125 The only non-icon changes are EliverLara/candy-icons@faea9d0 and EliverLara/candy-icons@fac60f0 to |
First PR, if I made some mistakes feel free to correct me :)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)cc @clr-cera
Add a 👍 reaction to pull requests you find important.