Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

candy-icons: unstable-2023-12-31 -> 0-unstable-2024-10-22 #351624

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

arunoruto
Copy link
Contributor

@arunoruto arunoruto commented Oct 27, 2024

First PR, if I made some mistakes feel free to correct me :)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @clr-cera


Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Oct 27, 2024
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 27, 2024
@arunoruto arunoruto force-pushed the master branch 2 times, most recently from 53007a2 to 2a25ce1 Compare October 27, 2024 12:06
@arunoruto
Copy link
Contributor Author

Result of nixpkgs-review pr 351624 run on x86_64-linux 1

1 package built:
  • candy-icons

@arunoruto
Copy link
Contributor Author

@tomberek

zakame
zakame previously requested changes Oct 27, 2024
Copy link
Member

@zakame zakame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for the PR and welcome to the community! 🎉

I recall the maintainer-list.nix file having its own formatting rules, so please undo the formatting changes, other than the addition of your identity to the list. Thank you! 🙇

@arunoruto
Copy link
Contributor Author

Hello, thanks for the PR and welcome to the community! 🎉

I recall the maintainer-list.nix file having its own formatting rules, so please undo the formatting changes, other than the addition of your identity to the list. Thank you! 🙇

Hi, thanks for the hint! I guess it is fixed now!

@arunoruto arunoruto requested a review from zakame October 27, 2024 14:34
@arunoruto arunoruto changed the title candy-icons: unstable-2023-12-31 -> 2024-10-22 candy-icons: unstable-2023-12-31 -> 0-unstable-2024-10-22 Oct 27, 2024
@arunoruto arunoruto requested a review from jtojnar October 27, 2024 16:39
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 27, 2024
@arunoruto arunoruto requested a review from zakame October 28, 2024 09:19
@clr-cera
Copy link
Contributor

Looks good to me!

@jtojnar
Copy link
Member

jtojnar commented Oct 28, 2024

For the record the upstream diff: EliverLara/candy-icons@e4464d7...f8a4125

The only non-icon changes are EliverLara/candy-icons@faea9d0 and EliverLara/candy-icons@fac60f0 to index.theme.

@jtojnar jtojnar merged commit dc40235 into NixOS:master Oct 28, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants