Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rime-ls: init at 0.4.0 #351508

Merged
merged 1 commit into from
Nov 26, 2024
Merged

rime-ls: init at 0.4.0 #351508

merged 1 commit into from
Nov 26, 2024

Conversation

definfo
Copy link
Contributor

@definfo definfo commented Oct 26, 2024

Description of change

See #345612

rime-ls is a language server for Rime input method engine.

Homepage: https://github.com/wlh320/rime-ls

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Oct 26, 2024
@definfo definfo requested a review from Vonfry October 27, 2024 04:36
@Vonfry
Copy link
Member

Vonfry commented Oct 28, 2024

Please use rebase to squash commits.

@definfo
Copy link
Contributor Author

definfo commented Nov 1, 2024

Not sure if I've made it correctly upstream :(

@definfo definfo requested a review from Vonfry November 5, 2024 17:45
Copy link
Member

@Vonfry Vonfry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@definfo
Copy link
Contributor Author

definfo commented Nov 6, 2024

cc @NickCao

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 6, 2024
@definfo
Copy link
Contributor Author

definfo commented Nov 9, 2024

Remove pkg-config as is unused.

@definfo definfo requested a review from NickCao November 9, 2024 15:05
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 10, 2024
@definfo definfo requested a review from NickCao November 10, 2024 02:51
@definfo definfo force-pushed the init-rime-ls branch 2 times, most recently from 9f96a55 to f479241 Compare November 24, 2024 07:17
NOTE: Currently rime-data is only used to pass checkPhase. Users may need to set RIME_DATA_DIR and configure editors themselves.
@Aleksanaa Aleksanaa merged commit a833a6d into NixOS:master Nov 26, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants