Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

micropython: 1.23.0 -> 1.24.0 #351427

Merged
merged 1 commit into from
Oct 26, 2024
Merged

micropython: 1.23.0 -> 1.24.0 #351427

merged 1 commit into from
Oct 26, 2024

Conversation

jwillikers
Copy link
Contributor

https://github.com/micropython/micropython/releases/tag/v1.24.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from stigtsp and prusnak October 26, 2024 14:59
stigtsp
stigtsp approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stigtsp stigtsp merged commit f8e0816 into NixOS:master Oct 26, 2024
31 of 32 checks passed
@jwillikers jwillikers deleted the micropython-1.24.0 branch October 26, 2024 16:18
@LeSuisse
Copy link
Contributor

Flagging as security related, it fixes CVE-2024-8946 and CVE-2024-8948. It looks like we need to backport the fixes to stable.

@LeSuisse LeSuisse added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 28, 2024
@prusnak prusnak mentioned this pull request Oct 28, 2024
Merged
13 tasks
@prusnak
Copy link
Member

prusnak commented Oct 28, 2024

backport in #351871

@prusnak prusnak added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwillikers @LeSuisse @prusnak @stigtsp