Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabric: init at 1.4.72 #351426

Closed
wants to merge 2 commits into from
Closed

fabric: init at 1.4.72 #351426

wants to merge 2 commits into from

Conversation

DJE98
Copy link

@DJE98 DJE98 commented Oct 26, 2024

I initially added the Fabric terminal application, written in Go, in version 1.4.72. This package was built and installed on the x86_64 architecture under NixOS 24.05. After building the package, I manually tested the application with locally running LLMs, confirming that all functionalities operated as expected without any issues.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Oct 26, 2024
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 26, 2024
@zi3m5f zi3m5f added the 2.status: duplicate This is a duplicate of another issue or PR label Oct 26, 2024
@zi3m5f
Copy link
Contributor

zi3m5f commented Oct 26, 2024

Maybe you want to update the existing package instead?
Simply close this PR and create a new one with the update or change this one.
By the way you missed some points in the documentation. Perhaps you want to compare your file with the existing one ;)

@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Nov 8, 2024
@aucub aucub closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: duplicate This is a duplicate of another issue or PR 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle! awaiting_changes (old Marvin label, do not use)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants