Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/lib/testing: remove alias usage #351424

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 26, 2024

Before I got this error:

 ➜ command nix-build -A nixosTests.portunus
error:
       … while evaluating the attribute 'drvPath'
         at /home/user/src/nixpkgs/lib/customisation.nix:365:7:
          364|     in commonAttrs // {
          365|       drvPath = assert condition; drv.drvPath;
             |       ^
          366|       outPath = assert condition; drv.outPath;

       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:34:12:
           33|
           34|   strict = derivationStrict drvAttrs;
             |            ^
           35|

       … while evaluating the module argument `pkgs' in "/home/user/src/nixpkgs/nixos/modules/services/hardware/bluetooth.nix":

       … while evaluating the option `nodes.machine.nixpkgs.localSystem':

       … while evaluating the option `nodes.machine.nixpkgs.system':

       … while evaluating definitions from `/home/user/src/nixpkgs/nixos/lib/testing/nodes.nix':

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: attribute 'hostPlatform' missing
       at /home/user/src/nixpkgs/nixos/lib/testing/nodes.nix:16:22:
           15|
           16|   inherit (hostPkgs) hostPlatform;
             |                      ^
           17|
       Did you mean rustPlatform?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules labels Oct 26, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 26, 2024
Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had this issue, verified fixes it in my config.

@SuperSandro2000 SuperSandro2000 merged commit 31513aa into NixOS:master Oct 27, 2024
47 checks passed
@SuperSandro2000 SuperSandro2000 deleted the testing-nodes-alias branch October 27, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants