Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsForQt5.k3b: fix build #351083

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

libsForQt5.k3b: fix build #351083

wants to merge 2 commits into from

Conversation

ethorsoe
Copy link

@ethorsoe ethorsoe commented Oct 25, 2024

fix k3b compile with ffmpeg-6 with upstream patches

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@K900
Copy link
Contributor

K900 commented Oct 25, 2024

Should we maybe just drop it in favor of the Qt6 version at this point? It feels like a lot of work to keep it alive.

@FliegendeWurst
Copy link
Member

Related: #348919

@ofborg ofborg bot requested a review from svanderburg October 25, 2024 06:44
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 25, 2024
@ethorsoe
Copy link
Author

Whatever, just as long as we don't have the most prominent k3b broken and referred by k3b module nixos/modules/programs/k3b.nix.

i think if we do not merge this (or a similar fix) the broken package should be removed so others do not waste time on it.

@FliegendeWurst
Copy link
Member

PR to fix nixos/k3b and remove libsForQt5.k3b: #351093

@ethorsoe
Copy link
Author

I'll leave this open, until it's decided what is to be done.

@FliegendeWurst FliegendeWurst changed the title K3bfix libsForQt5.k3b: fix build Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants