Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts_query_ls: init at 1.0.1 #350834

Merged
merged 2 commits into from
Dec 1, 2024
Merged

ts_query_ls: init at 1.0.1 #350834

merged 2 commits into from
Dec 1, 2024

Conversation

ribru17
Copy link
Contributor

@ribru17 ribru17 commented Oct 24, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ribru17 ribru17 force-pushed the ts_query_ls branch 2 times, most recently from ee3ab87 to 8fa759b Compare October 25, 2024 14:57
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 25, 2024
@ribru17 ribru17 changed the title feat: ts_query_ls at v1.0.0 feat: ts_query_ls at v1.0.1 Oct 27, 2024
@FliegendeWurst FliegendeWurst added the 11.by: upstream-developer This issue or PR was created by the developer of packaged software label Nov 8, 2024
FliegendeWurst
FliegendeWurst requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package looks good. Please make sure your commit messages follows CONTRIBUTING.md

maintainers/maintainer-list.nix Show resolved Hide resolved
@ribru17
Copy link
Contributor Author

ribru17 commented Nov 8, 2024

Thank you for the review :)

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 8, 2024
@uncenter
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350834

aarch64-darwin

✅ 1 package built:
  • ts_query_ls

@uncenter uncenter added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 14, 2024
isabelroses
isabelroses approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350834

x86_64-linux

✅ 1 package built:
  • ts_query_ls

@isabelroses isabelroses added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Nov 16, 2024
isabelroses
isabelroses reviewed Nov 17, 2024
View reviewed changes
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you can drop the v from the commit e.g. ts_query_ls: init at 1.0.1

pkgs/by-name/ts/ts_query_ls/Cargo.lock Outdated Show resolved Hide resolved
@isabelroses isabelroses removed the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Nov 17, 2024
@uncenter
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350834

aarch64-darwin

✅ 1 package built:
  • ts_query_ls

@uncenter uncenter added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2024
isabelroses
isabelroses approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350834

aarch64-darwin

✅ 1 package built:
  • ts_query_ls

@isabelroses isabelroses added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 17, 2024
@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Nov 17, 2024
@uncenter
Copy link
Member

For searchability do you want to update the PR title to match the commit message? feat: ts_query_ls at v1.0.1 -> ts_query_ls: init at 1.0.1. Other than that this still looks good, hopefully we can get this merged!

@ribru17 ribru17 changed the title feat: ts_query_ls at v1.0.1 ts_query_ls: init at 1.0.1 Dec 1, 2024
@ribru17 @FliegendeWurst
ts_query_ls: init at 1.0.1
c9a3c08 
Co-authored-by: Arne Keller <[email protected]>
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Dec 1, 2024
@wolfgangwalther
Copy link
Contributor

Result of nixpkgs-review pr 350834 run on aarch64-darwin 1

1 package built:
  • ts_query_ls

@wolfgangwalther
Copy link
Contributor

Result of nixpkgs-review pr 350834 run on x86_64-linux 1

1 package built:
  • ts_query_ls

@wolfgangwalther wolfgangwalther merged commit 0dda2b6 into NixOS:master Dec 1, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelroses isabelroses isabelroses approved these changes

@uncenter uncenter uncenter approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes 11.by: upstream-developer This issue or PR was created by the developer of packaged software 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ribru17 @uncenter @wolfgangwalther @FliegendeWurst @isabelroses @wegank