nixos/auto-cpufreq: init vm test #350507
nixos/auto-cpufreq: init vm test #350507
Conversation
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
|
@ofborg test auto-cpufreq |
|
Ha! That actually triggered the test to be executed :) You might want to add Other than that, (as you said) the test is basic, but is probably better than nothing. |
@NiklasGollenstede #350511 is moving |
| # service will still start but since vm inside qemu cpufreq adjustments | ||
| # cannot be made. This will resource in the following error but the service | ||
| # remains up: | ||
| # ERROR: |
There was a problem hiding this comment.
Isn't this error misleading? I guess it's documented here and thus expected, but still not great.
There was a problem hiding this comment.
I agree but theres no way Im aware of to supress the error inside of qemu
Even though cpufreq cannot be adjusted within qemu this test is still useful to ensure that the service is running and the auto-cpufreq cli is able to interact with the auto-cpufreq service.
sarcasticadmin
force-pushed
the
rh/1729536342
branch
from
1fe0ee0 to
c574ade
Compare
|
@NiklasGollenstede #350511 was merged so Ive added the |
Include a vm test for the auto-cpufreq nixos module
Even though cpufreq cannot be adjusted within qemu this test is still
useful to ensure that the service is running and the auto-cpufreq cli is
able to interact with the auto-cpufreq service.
This helped me troubleshoot the existing errors raised in: #347804
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.