Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline: init at 2.0.2 #350476

Merged
merged 1 commit into from
Oct 23, 2024
Merged

pipeline: init at 2.0.2 #350476

merged 1 commit into from
Oct 23, 2024

Conversation

chuangzhu
Copy link
Contributor

@chuangzhu chuangzhu commented Oct 22, 2024 •
edited
Loading

Pipeline, previously known as Tubefeeder, is a YouTube and PeerTube client.

Pipeline

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 22, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 23, 2024
JohnRTitor
JohnRTitor reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the package is officially from GNOME? If not, it should not be prefixed with gnome-.

@chuangzhu
Copy link
Contributor Author

chuangzhu commented Oct 23, 2024 •
edited
Loading

@JohnRTitor I thought the name pipeline may be too generic (sounds like a CI runner). Maybe its previous name tubefeeder is more appropriate for a package name? Idk

@Aleksanaa
Copy link
Member

@JohnRTitor I thought the name pipeline may be too generic (sounds like a CI runner). Maybe its previous name tubefeeder is more appropriate for a package name? Idk

Just call it pipeline. Anyway everyone knows this is ONLY GNOME DEVS CAN DO

@chuangzhu chuangzhu changed the title gnome-pipeline: init at 2.0.2 pipeline: init at 2.0.2 Oct 23, 2024
Aleksanaa
Aleksanaa approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@chuangzhu
Copy link
Contributor Author

Nevermind, I just found that using gdk-pixbuf's setupHook can achieve the same thing

I was wrong again - _gdkPixbufCacheBuilder_DO_NOT_USE is indeed needed. What webp-pixbuf-loader has is lib/gdk-pixbuf-2.0/2.10.0/webp-loaders.cache not lib/gdk-pixbuf-2.0/2.10.0/loaders.cache, so gdk-pixbuf.setupHook wasn't able to pick it up. Pipeline cached WebP images as JPEGs under ~/.cache/tubefeeder/ and hided the problem. I'm reverting the GDK_PIXBUF_MODULE_FILE change

@JohnRTitor JohnRTitor merged commit 4545ad6 into NixOS:master Oct 23, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRTitor JohnRTitor JohnRTitor left review comments

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chuangzhu @Aleksanaa @JohnRTitor