Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/bat: init bat module #350079

Merged
merged 1 commit into from
Dec 10, 2024
Merged

nixos/bat: init bat module #350079

merged 1 commit into from
Dec 10, 2024
+127 −1

Conversation

SigmaSquadron
Copy link
Contributor

Adds a module for bat. Bat's configuration format is pretty difficult to translate into a structured Nix submodule, so I'd appreciate some help in converting this extraConfig to the RFC 0042 standard.

Things done

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 20, 2024
@SigmaSquadron SigmaSquadron force-pushed the bat-module branch 3 times, most recently from bc243bf to a97e78a Compare October 20, 2024 19:10
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 20, 2024
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Oct 22, 2024
SuperSandro2000
SuperSandro2000 reviewed Nov 12, 2024
View reviewed changes
nixos/modules/programs/bat.nix Outdated Show resolved Hide resolved
nixos/modules/programs/bat.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Nov 13, 2024
@SigmaSquadron SigmaSquadron force-pushed the bat-module branch 6 times, most recently from c5c5a71 to 6da6c6e Compare November 15, 2024 17:40
@SigmaSquadron
Copy link
Contributor Author

SigmaSquadron commented Nov 15, 2024 •
edited
Loading

Now targeting NixOS 25.05.

I'm not sure why the manual CI is failing. It succeeds locally.

@SigmaSquadron SigmaSquadron force-pushed the bat-module branch 3 times, most recently from 2724510 to 5f48450 Compare November 17, 2024 15:23
@llakala
Copy link
Contributor

llakala commented Nov 17, 2024

For getting extraConfig to conform to RFC 42, referencing the home-manager module may be helpful.

@SigmaSquadron SigmaSquadron force-pushed the bat-module branch 2 times, most recently from f5efe1e to ca516a0 Compare November 20, 2024 02:26
@SigmaSquadron
Copy link
Contributor Author

SigmaSquadron commented Nov 20, 2024 •
edited
Loading

I went with pkgs.formats.keyValue and mapAttrs' instead. The home-manager setup is stupidly complex and pretty unnecessary, considering almost all options that don't have a value are aliases of options that do.

@SigmaSquadron SigmaSquadron force-pushed the bat-module branch 2 times, most recently from f36897e to 7f7d836 Compare November 20, 2024 08:07
@SigmaSquadron SigmaSquadron force-pushed the bat-module branch 2 times, most recently from dba9cf9 to a40d2ee Compare December 9, 2024 16:16
@SigmaSquadron
Copy link
Contributor Author

Hey, this should be ready for review. Merge conflicts have been fixed.

@SigmaSquadron
nixos/bat: init bat module
3a068ac 
Signed-off-by: Fernando Rodrigues <[email protected]>
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4943

@misuzu misuzu merged commit 22b87b1 into NixOS:master Dec 10, 2024
21 of 22 checks passed
@SigmaSquadron SigmaSquadron deleted the bat-module branch December 11, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misuzu misuzu misuzu approved these changes

@bbigras bbigras Awaiting requested review from bbigras

@dywedir dywedir Awaiting requested review from dywedir

@zowoq zowoq Awaiting requested review from zowoq

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SigmaSquadron @llakala @nixos-discourse @misuzu @SuperSandro2000 @h7x4