Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefly-iii-data-importer: 1.5.5 -> 1.5.6 #341746

Merged
merged 1 commit into from
Sep 23, 2024
Merged

firefly-iii-data-importer: 1.5.5 -> 1.5.6 #341746

merged 1 commit into from
Sep 23, 2024

Conversation

savyajha
Copy link
Contributor

@savyajha savyajha commented Sep 14, 2024 •
edited
Loading

Description of changes

Changes: firefly-iii/data-importer@v1.5.5...v1.5.6

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 14, 2024
@savyajha
Copy link
Contributor Author

Tests pass on my machine

@MinerSebas
Copy link
Contributor

For me accessing the importer i get a 502 Bad Gateway error from nginx.

From journalctl:

Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[258]: Warning: require(/nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/../symfony/polyfill-mbstring/bootstrap.php): Failed to open stream: No such file or directory in /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php on line 41
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[258]: Fatal error: Uncaught Error: Failed opening required '/nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/../symfony/polyfill-mbstring/bootstrap.php' (include_path='.:/nix/store/jv2c0ycnxx39s5bgx09s6hsildibpiwp-php-8.3.11/lib/php') in /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php:41
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[258]: Stack trace:
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[258]: #0 /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php(45): {closure}('0e6d7bf4a5811bf...', '/nix/store/3l7z...')
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[258]: #1 /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/autoload.php(25): ComposerAutoloaderInit5e97d14bc220a6acc1d0cdb90b71ee13::getLoader()
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[258]: #2 /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/artisan(18): require('/nix/store/3l7z...')
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[258]: #3 {main}
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[258]:   thrown in /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php on line 41
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[262]: Warning: require(/nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/../symfony/polyfill-mbstring/bootstrap.php): Failed to open stream: No such file or directory in /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php on line 41
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[262]: Fatal error: Uncaught Error: Failed opening required '/nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/../symfony/polyfill-mbstring/bootstrap.php' (include_path='.:/nix/store/jv2c0ycnxx39s5bgx09s6hsildibpiwp-php-8.3.11/lib/php') in /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php:41
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[262]: Stack trace:
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[262]: #0 /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php(45): {closure}('0e6d7bf4a5811bf...', '/nix/store/3l7z...')
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[262]: #1 /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/autoload.php(25): ComposerAutoloaderInit5e97d14bc220a6acc1d0cdb90b71ee13::getLoader()
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[262]: #2 /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/artisan(18): require('/nix/store/3l7z...')
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[262]: #3 {main}
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[262]:   thrown in /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php on line 41
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[263]: Warning: require(/nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/../symfony/polyfill-mbstring/bootstrap.php): Failed to open stream: No such file or directory in /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php on line 41
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[263]: Fatal error: Uncaught Error: Failed opening required '/nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/../symfony/polyfill-mbstring/bootstrap.php' (include_path='.:/nix/store/jv2c0ycnxx39s5bgx09s6hsildibpiwp-php-8.3.11/lib/php') in /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php:41
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[263]: Stack trace:
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[263]: #0 /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php(45): {closure}('0e6d7bf4a5811bf...', '/nix/store/3l7z...')
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[263]: #1 /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/autoload.php(25): ComposerAutoloaderInit5e97d14bc220a6acc1d0cdb90b71ee13::getLoader()
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[263]: #2 /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/artisan(18): require('/nix/store/3l7z...')
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[263]: #3 {main}
Sep 15 13:52:10 firefly-importer cj70z5drbmr01msd8j23bfb6g5d29zzv-data-importer-maintenance.sh[263]:   thrown in /nix/store/3l7zg36vyvgxjyqm3f4i2dbybgpwc7w0-firefly-iii-data-importer-1.5.6/vendor/composer/autoload_real.php on line 41

BUT, i also get the same error for 1.5.5 of the data-importer and the main firefly package.
All my testing was done on a aarch64-linux machine.

@MinerSebas
Copy link
Contributor

After bisecting this Repo, the PR that broke this seems to be #340072 which updated php.packages.composer.

@savyajha savyajha mentioned this pull request Sep 16, 2024
Closed
@savyajha
Copy link
Contributor Author

@MinerSebas Would you mind checking now? I think this should work.

MinerSebas
MinerSebas approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@MinerSebas MinerSebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, now the importer works correctly.

Overriding the main firefly package with the env-var also fixes the Problem there.
services.firefly-iii.package = pkgs.firefly-iii.overrideAttrs { env.COMPOSER_MIRROR_PATH_REPOS = "1"; };

@savyajha
Copy link
Contributor Author

Way ahead of you :) #342556

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 17, 2024
@savyajha savyajha requested a review from drupol September 23, 2024 06:06
@savyajha
Copy link
Contributor Author

@drupol Removed the environment variable after your fix. This is a straightforward version bump now.

@drupol drupol merged commit d40eb2f into NixOS:master Sep 23, 2024
26 checks passed
@savyajha savyajha deleted the data-importer branch September 23, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinerSebas MinerSebas MinerSebas approved these changes

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savyajha @MinerSebas @drupol @wegank