Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
types.attrTag
#284551Add
types.attrTag
#284551Changes from all commits
ca81a89
0feea2d
2ceb555
1ad3077
6949bc2
5b49672
42d3b54
0bc9783
e090bb5
4c7d990
2e1d470
475a55b
c0f54d3
fa8b46a
bcd7746
1465777
47e4a18
2d791b5
f354686
74831d8
cf4968a
22d7f14
35fe538
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a potential minor issue with supporting type merging, because users may write code like this:
And if some third-party module specifies another tag, this code breaks, without any good way to fix it.
Though I guess if we document that code needs to handle arbitrarily many tags, it might be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your example looks like a usage of
enum
.Indeed
attrTag
has that same characteristic, but I don't think this will happen by accident.Regarding the sameness:
enum [str1 .. strn]
is dual to an attrset of values.attrTag ...
is dual to an attrset of functions.