openxr-hpp: init at 1.0.26 #206491
Open
openxr-hpp: init at 1.0.26 #206491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiruyaMomochi
force-pushed
the
openxr-hpp-1.0.26
branch
from
d3c5ca2 to
9a0066b
Compare
ofborg
bot
added
8.has: package (new)
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
| meta = with lib; { | ||
| description = "Open-Source OpenXR C++ language projection"; | ||
| homepage = "https://github.com/KhronosGroup/OpenXR-Hpp"; | ||
| license = licenses.asl20; |
There was a problem hiding this comment.
Let's add changelog:
Suggested change
| license = licenses.asl20; | |
| changelog = "https://github.com/KhronosGroup/OpenXR-Hpp/releases/tag/release-${version}"; | |
| license = licenses.asl20; |
Comment on lines
+24335
to
+24336
| openxr-hpp = callPackage ../development/libraries/openxr-hpp { }; | ||
|
|
There was a problem hiding this comment.
New packages should go to pkgs/by-name nowadays.
Suggested change
| openxr-hpp = callPackage ../development/libraries/openxr-hpp { }; |
stale
bot
removed
the
2.status: stale
|
Also, please get rid of the merge commit when rebasing. |
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Open-Source OpenXR C++ language projection
https://github.com/KhronosGroup/OpenXR-Hpp
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes