Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inkscape-extensions.living_hinge: init at unstable-2020-01-21 #193431

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MatthewCroughan
Copy link
Contributor

@MatthewCroughan MatthewCroughan commented Sep 28, 2022

Description of changes

Adds an extension that allows the creation of so-called "living hinge" vector paths in inkscape, usually for laser cutting purposes. This only seems to work with Inkscape 1.1.2 and not 1.2, which is in master now. But I still think it's worth including.

You can test this out by doing:

nix shell --impure --expr '(import (builtins.getFlake "github:nixos/nixpkgs/nixos-22.05") {}).inkscape-with-extensions.override { inkscapeExtensions = [(import (builtins.getFlake "github:matthewcroughan/nixpkgs/mc/inkscape-living-hinge") {}).inkscape-extensions.living_hinge]; }'

And then running inkscape.

image

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great plugin, some comments

description = "This is an extension for creating living hinges in Inkscape.";
homepage = "https://github.com/lifelike/hexmapextension";
license = licenses.gpl2Plus;
maintainers = [ maintainers.raboof ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be interested in maintaining it yourself? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derp

runHook postInstall
'';

meta = with lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe good to mark it 'broken' since it doesn't work with the inkscape in this nixpkgs, and document how to run it with an older inkscape?

It would be nice to track inkscape 1.2 support in an upstream issue, perhaps at https://github.com/drphonon/Inkscape_LivingHinge ?

pkgs/applications/graphics/inkscape/extensions.nix Outdated Show resolved Hide resolved
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
'';

meta = with lib; {
description = "This is an extension for creating living hinges in Inkscape.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "This is an extension for creating living hinges in Inkscape.";
description = "Extension for creating living hinges in Inkscape";

@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Nov 18, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants