-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inkscape-extensions.living_hinge: init at unstable-2020-01-21 #193431
base: master
Are you sure you want to change the base?
inkscape-extensions.living_hinge: init at unstable-2020-01-21 #193431
Conversation
ba8fbff
to
cf955fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great plugin, some comments
description = "This is an extension for creating living hinges in Inkscape."; | ||
homepage = "https://github.com/lifelike/hexmapextension"; | ||
license = licenses.gpl2Plus; | ||
maintainers = [ maintainers.raboof ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be interested in maintaining it yourself? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Derp
runHook postInstall | ||
''; | ||
|
||
meta = with lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe good to mark it 'broken' since it doesn't work with the inkscape in this nixpkgs, and document how to run it with an older inkscape?
It would be nice to track inkscape 1.2 support in an upstream issue, perhaps at https://github.com/drphonon/Inkscape_LivingHinge ?
Co-authored-by: Arnout Engelen <[email protected]>
''; | ||
|
||
meta = with lib; { | ||
description = "This is an extension for creating living hinges in Inkscape."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "This is an extension for creating living hinges in Inkscape."; | |
description = "Extension for creating living hinges in Inkscape"; |
Description of changes
Adds an extension that allows the creation of so-called "living hinge" vector paths in inkscape, usually for laser cutting purposes. This only seems to work with Inkscape 1.1.2 and not 1.2, which is in master now. But I still think it's worth including.
You can test this out by doing:
nix shell --impure --expr '(import (builtins.getFlake "github:nixos/nixpkgs/nixos-22.05") {}).inkscape-with-extensions.override { inkscapeExtensions = [(import (builtins.getFlake "github:matthewcroughan/nixpkgs/mc/inkscape-living-hinge") {}).inkscape-extensions.living_hinge]; }'
And then running
inkscape
.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes