vscode: improve update_installed_exts.sh #192849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Redirect stderr, because some vscode wrappers (like nixpkgs' vscodeEnv) will print info that breaks this script. - Add EXCLUDE param to exclude some extensions from being updated, which is useful for installed extensions that aren't in the marketplace.
ofborg
bot
added
10.rebuild-darwin: 0
|
@jonringer, please review if you get a chance |
|
Still looking for a reviewer, maybe @bobby285271 ? |
|
@SuperSandro2000 I've tried a couple people but can't find a reviewer for this, can you help? |
Comment on lines
+6
to
+10
| # Optional EXCLUDE env var can be set to a string with a space-separated list | ||
| # of extensions to exclude from the output, e.g.: | ||
| # $ EXCLUDE="pub1.foo pub2.bar" ./update_installed_exts.sh | ||
| # | ||
| # Can be added to your configuration with the following command and snippet: |
There was a problem hiding this comment.
If this is piped anyway, wouldn't it be easier to just use grep to filter?
wegank
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested both of these cases with my own use-case.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes