-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/nextcloud: Add default for option hostName #183977
base: master
Are you sure you want to change the base?
Conversation
@@ -8,6 +8,8 @@ let | |||
|
|||
jsonFormat = pkgs.formats.json {}; | |||
|
|||
fqdn = if config.networking.domain != null then config.networking.fqdn else config.networking.hostName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting an fqdn to a hostname by default seems wrong to me. Perhaps we should only set the default if networking.domain != null
?
e82ad26
to
3f95039
Compare
@Ma27 would be default value "localhost" for hostName okay? |
I'm sorry, I fail to understand the motivation behind that: that's by default the only value in trusted_domains and in the most cases |
Description of changes
Sets default hostName to
``` if config.networking.domain != null then "nextcloud.${config.networking.fqdn}" else "nextcloud.${config.networking.hostName}" ```Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes