Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nextcloud: Add default for option hostName #183977

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

onny
Copy link
Contributor

@onny onny commented Jul 30, 2022

Description of changes

Sets default hostName to

localhost
``` if config.networking.domain != null then "nextcloud.${config.networking.fqdn}" else "nextcloud.${config.networking.hostName}" ```
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@onny onny requested a review from Ma27 July 30, 2022 14:53
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 30, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 30, 2022
@@ -8,6 +8,8 @@ let

jsonFormat = pkgs.formats.json {};

fqdn = if config.networking.domain != null then config.networking.fqdn else config.networking.hostName;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting an fqdn to a hostname by default seems wrong to me. Perhaps we should only set the default if networking.domain != null?

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@onny onny force-pushed the nextcloud-hostname branch from e82ad26 to 3f95039 Compare March 30, 2024 10:23
@onny onny requested a review from Ma27 March 30, 2024 10:26
@onny
Copy link
Contributor Author

onny commented Mar 30, 2024

@Ma27 would be default value "localhost" for hostName okay?

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 30, 2024
@onny onny requested a review from mohe2015 March 31, 2024 10:16
@Ma27
Copy link
Member

Ma27 commented Apr 1, 2024

would be default value "localhost" for hostName okay?

I'm sorry, I fail to understand the motivation behind that: that's by default the only value in trusted_domains and in the most cases localhost isn't what you want there or in your reverse proxy.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 3, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants