openssl: Support no-deprecated & no-tests

[IceCodeNew]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[IceCodeNew]

Re-open #180452

[IceCodeNew]

tested through commands

nix-channel --update
package_name=openssl
nix-build --no-out-link --expr "with import <nixpkgs> {}; (pkgsStatic.${package_name}).overrideAttrs (old: { configureFlags = (old.configureFlags or []) ++ [ \"no-tests\" \"no-deprecated\" ]; })"

[alyssais]

Something has gone wrong with your "openssl: Support sskipskippingthe tests" commit message. What's the reason for disabling the tests, just a faster build?

[alyssais]

Also, in your first commit you introduce the no-deprecated option at the end of the options list, but then in a later commit you move it. Could you please modify your commits so that it's introduced in your preferred location from the start? Otherwise it's pointlessly adding an extra cycle to somebody trying to use git blame in future.

[IceCodeNew]

What's the reason for disabling the tests, just a faster build?

Yes.
May I ask if there is a standard for what options are encouraged to be included in the nix formula, and what are not?
As the upstream has already left those options, It is not strange that someday the nix users will have asked for every single option to be tunable in the nix formula, right?
But such a complicated formula does not sound right to me. Am I abusing the nixpkgs repo?

[IceCodeNew]

Otherwise it's pointlessly adding an extra cycle to somebody trying to use git blame in future.

I was expecting this PR to be merge with the squash-ish way. Can we squash this PR when it is ready for merging?

[IceCodeNew]

It's been a week ago since this PR got reviewed, I'm wondering if @alyssais could spend some time guiding me to consummate this PR. Thanks ;-)

[IceCodeNew]

@alyssais @SuperSandro2000 I just resolved the conflict.
Should something is missing in getting this PR merged, would you please shed some light on me?