Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.drf-jwt: init at 1.19.0 #121825

Merged
merged 3 commits into from
May 21, 2021
Merged

pythonPackages.drf-jwt: init at 1.19.0 #121825

merged 3 commits into from
May 21, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented May 5, 2021 •
edited
Loading

Motivation for this change

closes #120957

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @critbase @ivegotasthma

@dotlambda dotlambda requested a review from SuperSandro2000 May 5, 2021 18:29
@dotlambda dotlambda requested review from FRidh and jonringer as code owners May 5, 2021 18:29
@dotlambda
Copy link
Member Author

Should we send @ivegotasthma an email before removing him?

@grahamc
Copy link
Member

grahamc commented May 5, 2021

Should we send @ivegotasthma an email before removing him?

Please do.

@dotlambda
Copy link
Member Author

dotlambda commented May 5, 2021 •
edited
Loading

I sent an email. Ofborg will fail cause I forgot to remove them from other packages.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 5, 2021
@grahamc
Copy link
Member

grahamc commented May 5, 2021

Note that we can have maintainers who do not have a GitHub account, so it is possible the only change is removing their github handle.

@dotlambda
Copy link
Member Author

No reaction so far. I wonder how long we should wait.

@dotlambda dotlambda mentioned this pull request May 12, 2021
Closed
10 tasks
dotlambda added 3 commits May 12, 2021 13:30
@dotlambda
pythonPackages.drf-jwt: init at 1.19.0
4aa6396
@dotlambda
pythonPackages.djangorestframework-jwt: make an alias of drf-jwt
0c53856 
As per jpadilla/django-rest-framework-jwt#484,
the latter is a drop-in replacement of the former, while the former is
unmaintained.
@dotlambda
maintainers: remove ivegotasthma
2aa6bce 
He disappeared from GitHub and doesn't reply to emails.
@dotlambda dotlambda merged commit 68f959d into NixOS:master May 21, 2021
@dotlambda dotlambda deleted the drf-jwt-init branch May 21, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotlambda @grahamc