Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

framework: Fix kernel version comparison for preventWakeOnAC #1237

Merged

Conversation

miketth
Copy link
Contributor

@miketth miketth commented Nov 10, 2024

Description of changes

The comparison previously used the default kernel's version instead of the selected kernel's version. This makes the comparison use the actually selected kernel's version.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

The comparison previously used the default kernel's version instead of the selected kernel's version.
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SuperSandro2000 SuperSandro2000 merged commit 184687a into NixOS:master Nov 11, 2024
2 checks passed
@miketth miketth deleted the framework-fix-kernel-version-comparison branch November 11, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants