Getting rid of unbounded shift. It looked nice, but introduced memory…

… access bugs. We should not shift over the size of values and hide it with this class.

crypto3.nix

@@ -46,8 +46,7 @@ in stdenv.mkDerivation {
     # JUNIT file without explicit file name is generated after the name of the master test suite inside `CMAKE_CURRENT_SOURCE_DIR`
     export BOOST_TEST_LOGGER=JUNIT:HRF
     cd crypto3
-    # remove || true after all tests are fixed under clang-sanitizers check:
-    ctest --verbose --output-on-failure -R > test_errors.txt || true
+    ctest --verbose --output-on-failure -R > test_errors.txt
     cd ..
     mkdir -p ${placeholder "out"}/test-logs
     find .. -type f -name '*_test.xml' -exec cp {} ${placeholder "out"}/test-logs \;

crypto3/libs/algebra/include/nil/crypto3/algebra/matrix/math.hpp

@@ -29,8 +29,6 @@
 
 #include <algorithm>
 
-#include <nil/crypto3/detail/assert.hpp>
-
 #include <nil/crypto3/algebra/vector/vector.hpp>
 #include <nil/crypto3/algebra/vector/math.hpp>
 

crypto3/libs/algebra/include/nil/crypto3/algebra/matrix/matrix.hpp

@@ -30,8 +30,6 @@
 #include <array>
 #include <tuple>
 
-#include <nil/crypto3/detail/assert.hpp>
-
 #include <nil/crypto3/algebra/vector/utility.hpp>
 #include <nil/crypto3/algebra/vector/vector.hpp>
 
@@ -52,8 +50,6 @@ namespace nil {
             struct matrix {
                 static_assert(N != 0 && M != 0, "matrix must have have positive dimensions");
 
-                // CRYPTO3_DETAIL_ASSERT_ARITHMETIC(T)
-
                 using value_type = T;
                 using size_type = std::size_t;
                 static constexpr size_type column_size = N;    ///< Number of rows

crypto3/libs/algebra/include/nil/crypto3/algebra/scalar/math.hpp

@@ -28,7 +28,6 @@
 #define CRYPTO3_ALGEBRA_SCALAR_MATH_HPP
 
 #include <nil/crypto3/algebra/type_traits.hpp>
-#include <nil/crypto3/detail/assert.hpp>
 
 namespace nil {
     namespace crypto3 {
@@ -74,7 +73,6 @@ namespace nil {
              */
             template<typename T>
             constexpr nil::crypto3::algebra::remove_complex_t<T> abs(T x) {
-                // CRYPTO3_DETAIL_ASSERT_ARITHMETIC(T);
                 if constexpr (algebra::is_complex_v<T>)
                     return sqrt(x.real() * x.real() + x.imag() * x.imag());
                 else
@@ -136,7 +134,6 @@ namespace nil {
              */
             template<typename T>
             constexpr T conj(T x) {
-                // CRYPTO3_DETAIL_ASSERT_ARITHMETIC(T);
                 if constexpr (algebra::is_complex_v<T>)
                     return {x.real(), -x.imag()};
                 else

crypto3/libs/algebra/include/nil/crypto3/algebra/vector/utility.hpp

@@ -28,6 +28,7 @@
 #define CRYPTO3_ALGEBRA_VECTOR_UTILITY_HPP
 
 #include <nil/crypto3/algebra/vector/vector.hpp>
+#include <nil/crypto3/detail/same_value.hpp>
 
 #include <tuple>
 

crypto3/libs/algebra/include/nil/crypto3/algebra/vector/vector.hpp

@@ -27,9 +27,6 @@
 #ifndef CRYPTO3_ALGEBRA_VECTOR_CLASS_HPP
 #define CRYPTO3_ALGEBRA_VECTOR_CLASS_HPP
 
-#include <nil/crypto3/detail/same_value.hpp>
-#include <nil/crypto3/detail/assert.hpp>
-
 #include <array>
 #include <cstddef>
 
@@ -49,7 +46,6 @@ namespace nil {
             template<typename T, std::size_t N>
             struct vector {
                 static_assert(N != 0, "vector must contain at least one element");
-                // CRYPTO3_DETAIL_ASSERT_ARITHMETIC(T)
 
                 using value_type = T;
                 using size_type = std::size_t;