Most common element - update for #29

src/listwiz/inspect.py

@@ -6,6 +6,8 @@
 
 """
 
+from collections import Counter
+
 
 def largest_element(l):
     """Find the largest element and its index
@@ -55,13 +57,6 @@ def most_common_element(ll):
     if not isinstance(ll, list):
         raise ValueError("Input must be a list")
 
-    counting ={}
-    for i in ll:
-        if i in counting:
-            counting[i] += 1
-        else:
-            counting[i] = 1
-
-    # Find the key with the maximum value
-    most_common = max(counting, key=counting.get)
-    return most_common  
+    c = Counter(ll)
+    return c.most_common(1)[0][0]
+

tests/test_inspect.py

@@ -31,5 +31,3 @@ def test_most_common_element():
     ll = [1, 2, 3, 4, 1, 1, 2, 3, 3, 3, 3, 3]
     res = lwi.most_common_element(ll)
     assert res == 3
-
-