Most common element

[gudlot]

This is my suggestion for an implementation of the function most_common_element with pure Python commands, not using numpy. :-)
A test was provided.

[seberg]

Thanks, if we were more series, I would expect improving with Counter, and likely have another iteration (for some other nitpicky/small thing).

As is, I think this is a great PR start. (A PR without any iteration is very rare even for year-long maintainers. Up to: "I am worried if something goes in without a comment").

So LGTM thanks you. I'll just apply the comment removal first.

[seberg]

You could also use from collections import Counter to avoid the if clause even. But considering how basic the project, is I think this is a perfect solution.

[gudlot]

Thank you for the update. I was not aware of Counter.

def most_common_element(ll):
   
    if not isinstance(ll, list):
        raise ValueError("Input must be a list")
    
    c = Counter(ll)
    return c.most_common(1)[0][0]

What do you mean by "likely have another iteration (for some other nitpicky/small thing)", please? Happy to learn.

[seberg]

Sorry, I meant that it is not uncommon for someone to have small (often tiny/silly) asks to improve things a bit more.

[gudlot]

Happy to improve, thank you for the input :-)

[seberg]

Ah, we could have added a Closes #XX to automatically fix the bug (and also link from it here to make it easier to find).

[Nikoleta-v3]

We could have added them but do we want to close the issues? Just in case we use the material again in the future.

[seberg]

Ah, good point. I closed the issues now... Maybe it makes sense to just reopen them anyway also (since they are linked, etc.)?

[Nikoleta-v3]

Sounds good to me!