bubble sort #26
Closed
bubble sort #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a great start. Unfortunately, we also need a test for this. You should find a small test stub. |
seberg
reviewed
Aug 27, 2024
| def bubble_sort(l): | ||
| # We should provide bubble sort as well! | ||
| raise NotImplementedError | ||
| def bubble_sort(arr): |
There was a problem hiding this comment.
This would need some documentation of course. At least for public facing functions.
| # Test even-sized list: | ||
| l = [3, 2, 1, 5, 4, 6] | ||
| res = lws.bubble_sort(l) | ||
| assert res == [1, 2, 3, 4, 5, 6] |
There was a problem hiding this comment.
This list of tests is good. One way one can write it more compact is for example pytest.mark.parametrize().
That way the input and expected results are parameter, and the repetitive code is a bit less (not much for the simple test). It also effectively splits it in multiple tests.
|
creating a new pull request with all the changes and closing this one |
|
You should be able to force-push, but OK :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just added bubble sort algo.