Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check config options as Booleans instead of strings #461

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Check config options as Booleans instead of strings #461

merged 2 commits into from
Apr 30, 2024

Conversation

epierce
Copy link
Member

@epierce epierce commented Apr 29, 2024

Description

Part of the code changes included with #440 was converting the True/False strings read in from the config file to Booleans. However, some of the code still expected those values to be strings. This change fixes the two remaining spots that expected them to be strings.

Related Issue

#459

How Has This Been Tested?

Tested on macOS w/ Python 3.12 - all tests have been updated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@epierce epierce merged commit 763ae83 into master Apr 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant