Replace getpass with ui.input(hidden=True) #429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm currently trying to automate gimme-aws-creds in a python script.
I admire the idea of the
gimme_aws_creds.ui.UserInterface
class that helps a lot in automating user input.I found that some places in the code was directly calling
getpass.getpass()
and not using the providedUserInterface
. Replacing those calls with the properUserInterface.input(hidden=True)
.Related Issue
Fixes #428
Motivation and Context
Allowing developers subclassing
gimme_aws_creds.ui.UserInterface
for automation to provide inputs for password themselves.How Has This Been Tested?
pytest -vv tests
with no errorsUserInterface
.Screenshots (if appropriate):
Types of changes
Checklist: