-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter webauthn by authenticatorName #292
base: master
Are you sure you want to change the base?
Conversation
hey @Sector95! any chance we could get a review on this? |
Hi @bwynsm, is there a chance you take a look at this? |
4a3d1cf
to
137184f
Compare
@pawelaugustyn @bwynsm I have rebased this pr unto the latest to fix the merge conflict. This is working for me when I have multiple authenticators on an account, I dont have to select from the list anymore. |
@zelch I will take a look. |
@zelch With my limited testing I have been running into issues with the 366 patch. my urllib and requests libs needed to be updated/replaced and that wasnt caught as part of the requirements.txt it seems. I kept throwing this error until I did that I had one successful run, now I am seeing this error. It seems 366 may not be totally reliable yet. |
You need to be using urllib3 1.26+ to use allowed_methods. I recommend upgrading your Requests and urllib3 versions. |
Handle the case where multiple webauthn keys are registered and you want to default to one.
eg you may have a macbook fingerprint and a yubikey both registered in okta but prefer the yubikey on certain devices.