Merge pull request #408 from longbowrocks/prevent_bad_device_token

Prevent bad device token
Nike-Inc · Jun 1, 2023 · 4f37919 · 4f37919
2 parents 679c30f + 4aee4ed
commit 4f37919
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/gimme_aws_creds/config.py b/gimme_aws_creds/config.py
@@ -253,7 +253,6 @@ def update_config_file(self):
             'preferred_mfa_type': '',
             'remember_device': 'n',
             'aws_default_duration': '3600',
-            'device_token': '',
             'output_format': 'export',
         }
 

diff --git a/gimme_aws_creds/main.py b/gimme_aws_creds/main.py
@@ -936,7 +936,7 @@ def handle_action_store_json_creds(self, stream=None):
 
     def handle_action_register_device(self):
         # Capture the Device Token and write it to the config file
-        if self.okta_platform == "classic" and ( self.device_token is None or self.config.action_register_device is True ):
+        if self.okta_platform == "classic" and ( not self.device_token or self.config.action_register_device is True ):
             if not self.config.action_register_device:
                 self.ui.notify('\n*** No device token found in configuration file, it will be created.')
                 self.ui.notify('*** You may be prompted for MFA more than once for this run.\n')