Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Commit

Permalink
Add server group and region dimensions to enable canary analysis with…
Browse files Browse the repository at this point in the history
… signalfx (#192)
  • Loading branch information
fieldju authored Mar 14, 2019
1 parent ceeed79 commit bbd8d1e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
# limitations under the License.
#

version=3.25.8
version=3.26.0
groupId=com.nike.cerberus
artifactId=cms
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ public SignalFxReporterFactory generateSignalFxReporterFactory(
String host = EC2MetadataUtils.getLocalHostName();
String ec2Hostname = EC2_HOSTNAME_PREFIX + EC2MetadataUtils.getPrivateIpAddress();

String serverGroup = System.getProperty("serverGroup", "unknown");
String serverRegion = System.getProperty("serverRegion", "unknown");

Function<SignalFxReporter.Builder, SignalFxReporter.Builder> defaultReporterConfigurator =
(builder) -> builder
.addUniqueDimension("host", host)
Expand All @@ -92,6 +95,8 @@ public SignalFxReporterFactory generateSignalFxReporterFactory(
.addUniqueDimension("env", signalFxAppEnvDim)
.addUniqueDimension("framework", "riposte")
.addUniqueDimension("app_version", serviceVersionDim)
.addUniqueDimension("server_group", serverGroup)
.addUniqueDimension("server_region", serverRegion)
.setDetailsToAdd(finalMetricDetailsToReport);

if (customReporterConfigurator == null)
Expand Down

0 comments on commit bbd8d1e

Please sign in to comment.