Fix cabal repl support
#50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how this package hacks into the Cabal build process, `cabal repl` didn't work: the `cbits` objects weren't built, and the object files weren't passed to the GHC invocation correctly. This commit fixes this hooking into the `replHook` from `Setup.hs`, and trigger a build of `cbits` objects, and adapting the `ghc-wrapper` script to detect `--interactive` usage of GHC, and adjust the command-line arguments accordingly. Note: `stack repl` doesn't work, because Stack seems to bypass `Setup.hs` in its implementation, see commercialhaskell/stack#970. See: commercialhaskell/stack#970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how this package hacks into the Cabal build process,
cabal repldidn't work: the
cbitsobjects weren't built, and the object filesweren't passed to the GHC invocation correctly.
This commit fixes this hooking into the
replHookfromSetup.hs, andtrigger a build of
cbitsobjects, and adapting theghc-wrapperscript to detect
--interactiveusage of GHC, and adjust thecommand-line arguments accordingly.
Note:
stack repldoesn't work, because Stack seems to bypassSetup.hsin its implementation, see commercialhaskell/stack#970.See: commercialhaskell/stack#970